Open
Conversation
Apply the current tracing migration and UI updates on chore/tracing-only-ui, remove golang-migrate installation from the web image, and keep compose/docs aligned for cached local builds.
Apply the current tracing migration and UI updates on chore/tracing-only-ui, remove golang-migrate installation from the web image, and keep compose/docs aligned for cached local builds.
Route tracing repositories to TRACING_DATABASE_URL while keeping Prisma metadata migrations on the primary DATABASE_URL, and update local-build compose wiring to bootstrap tracing schema before worker startup.
Switch tracing repository imports to use a live tracing Prisma binding to avoid undefined $queryRaw crashes at runtime, and add targeted startup dependencies in local-build compose so web/worker wait for required infra services.
Rename the Yugabyte service, keep metadata/tracing init explicit, and standardize schema wiring for local startup stability.
Point metadata bootstrap at the tracked yb_postgres_data.sql file to avoid mounting a directory as /schema/data.sql and failing first-run initialization.
Restore and apply the previously stashed local compose adjustments and web page tweak on top of mekodata-26-03-13.
Made-with: Cursor
Bring back metadata/tracing schema init services in docker-compose.yml and keep local-build compose envs aligned with tracing-only Yugabyte setup.
docker-compose.yml
Outdated
| - "${WEB_HOST_PORT:-3000}:3000" | ||
| environment: | ||
| # Metadata DB (Prisma migrations + metadata tables) | ||
| DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse" |
There was a problem hiding this comment.
hardcoded here, use this kinda syntax for allowing overriding from .env file
CLICKHOUSE_URL: ${CLICKHOUSE_URL:-http://clickhouse:8123}
docker-compose.yml
Outdated
| environment: | ||
| # Metadata DB (Prisma migrations + metadata tables) | ||
| DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse" | ||
| TRACING_DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse?schema=clickhouse" |
docker-compose.yml
Outdated
| restart: always | ||
| depends_on: *langfuse-depends-on | ||
| # ClickHouse (kept for env compatibility; tracing repositories use Postgres) | ||
| CLICKHOUSE_MIGRATION_URL: "clickhouse://${CLICKHOUSE_CONTAINER_NAME:-langfuse-clickhouse}:9000" |
There was a problem hiding this comment.
need to remove the click-house urls & post-gress urls
docker-compose.yml
Outdated
| LANGFUSE_S3_MEDIA_UPLOAD_REGION: "${LANGFUSE_S3_MEDIA_UPLOAD_REGION:-us-east-1}" | ||
| LANGFUSE_S3_MEDIA_UPLOAD_ACCESS_KEY_ID: "${LANGFUSE_S3_MEDIA_UPLOAD_ACCESS_KEY_ID:-minio}" | ||
| LANGFUSE_S3_MEDIA_UPLOAD_SECRET_ACCESS_KEY: "${LANGFUSE_S3_MEDIA_UPLOAD_SECRET_ACCESS_KEY:-miniosecret}" | ||
| LANGFUSE_S3_MEDIA_UPLOAD_ENDPOINT: "http://minio:9000" |
There was a problem hiding this comment.
port is hardcoded, make it a variable & allow to fetch from .env
"http://localhost:${MINIO_API_PORT:-19090}"
docker-compose.yml
Outdated
| LANGFUSE_S3_BATCH_EXPORT_BUCKET: "${LANGFUSE_S3_BATCH_EXPORT_BUCKET:-langfuse}" | ||
| LANGFUSE_S3_BATCH_EXPORT_PREFIX: "${LANGFUSE_S3_BATCH_EXPORT_PREFIX:-exports/}" | ||
| LANGFUSE_S3_BATCH_EXPORT_REGION: "${LANGFUSE_S3_BATCH_EXPORT_REGION:-us-east-1}" | ||
| LANGFUSE_S3_BATCH_EXPORT_ENDPOINT: "http://minio:9000" |
docker-compose.yml
Outdated
| - langfuse_clickhouse_data:/var/lib/clickhouse | ||
| - langfuse_clickhouse_logs:/var/log/clickhouse-server | ||
| # Metadata DB | ||
| DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse" |
| - sh | ||
| - -c | ||
| - | | ||
| bin/yugabyted start \ |
There was a problem hiding this comment.
@ashetkar could you please cross-review the configurations of yb image here please.
Drop clickhouse-only compose wiring and web startup hard-fail, and default legacy clickhouse env keys in web env schema so yugabyte-only local startup works.
Replace deprecated URL validation and provide defaults for ClickHouse worker env keys so local Yugabyte-only setups do not fail env parsing.
|
@krishna-yb As a standard practice, please update the description of the PR to include what was changed and why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Type of change
Mandatory Tasks
Checklist
pnpm run format)npm run lint)