Skip to content

Mekodata 26 03 13#2

Open
krishna-yb wants to merge 28 commits intomainfrom
mekodata-26-03-13
Open

Mekodata 26 03 13#2
krishna-yb wants to merge 28 commits intomainfrom
mekodata-26-03-13

Conversation

@krishna-yb
Copy link
Copy Markdown

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project (pnpm run format)
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings (npm run lint)
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

krishna-yb and others added 20 commits March 10, 2026 08:42
Apply the current tracing migration and UI updates on chore/tracing-only-ui, remove golang-migrate installation from the web image, and keep compose/docs aligned for cached local builds.
Apply the current tracing migration and UI updates on chore/tracing-only-ui, remove golang-migrate installation from the web image, and keep compose/docs aligned for cached local builds.
Route tracing repositories to TRACING_DATABASE_URL while keeping Prisma metadata migrations on the primary DATABASE_URL, and update local-build compose wiring to bootstrap tracing schema before worker startup.
Switch tracing repository imports to use a live tracing Prisma binding to avoid undefined $queryRaw crashes at runtime, and add targeted startup dependencies in local-build compose so web/worker wait for required infra services.
Rename the Yugabyte service, keep metadata/tracing init explicit, and standardize schema wiring for local startup stability.
Point metadata bootstrap at the tracked yb_postgres_data.sql file to avoid mounting a directory as /schema/data.sql and failing first-run initialization.
Restore and apply the previously stashed local compose adjustments and web page tweak on top of mekodata-26-03-13.
Bring back metadata/tracing schema init services in docker-compose.yml and keep local-build compose envs aligned with tracing-only Yugabyte setup.
- "${WEB_HOST_PORT:-3000}:3000"
environment:
# Metadata DB (Prisma migrations + metadata tables)
DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded here, use this kinda syntax for allowing overriding from .env file
CLICKHOUSE_URL: ${CLICKHOUSE_URL:-http://clickhouse:8123}

environment:
# Metadata DB (Prisma migrations + metadata tables)
DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse"
TRACING_DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse?schema=clickhouse"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as here

restart: always
depends_on: *langfuse-depends-on
# ClickHouse (kept for env compatibility; tracing repositories use Postgres)
CLICKHOUSE_MIGRATION_URL: "clickhouse://${CLICKHOUSE_CONTAINER_NAME:-langfuse-clickhouse}:9000"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the click-house urls & post-gress urls

LANGFUSE_S3_MEDIA_UPLOAD_REGION: "${LANGFUSE_S3_MEDIA_UPLOAD_REGION:-us-east-1}"
LANGFUSE_S3_MEDIA_UPLOAD_ACCESS_KEY_ID: "${LANGFUSE_S3_MEDIA_UPLOAD_ACCESS_KEY_ID:-minio}"
LANGFUSE_S3_MEDIA_UPLOAD_SECRET_ACCESS_KEY: "${LANGFUSE_S3_MEDIA_UPLOAD_SECRET_ACCESS_KEY:-miniosecret}"
LANGFUSE_S3_MEDIA_UPLOAD_ENDPOINT: "http://minio:9000"
Copy link
Copy Markdown

@kushidhar-in kushidhar-in Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port is hardcoded, make it a variable & allow to fetch from .env
"http://localhost:${MINIO_API_PORT:-19090}"

LANGFUSE_S3_BATCH_EXPORT_BUCKET: "${LANGFUSE_S3_BATCH_EXPORT_BUCKET:-langfuse}"
LANGFUSE_S3_BATCH_EXPORT_PREFIX: "${LANGFUSE_S3_BATCH_EXPORT_PREFIX:-exports/}"
LANGFUSE_S3_BATCH_EXPORT_REGION: "${LANGFUSE_S3_BATCH_EXPORT_REGION:-us-east-1}"
LANGFUSE_S3_BATCH_EXPORT_ENDPOINT: "http://minio:9000"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

- langfuse_clickhouse_data:/var/lib/clickhouse
- langfuse_clickhouse_logs:/var/log/clickhouse-server
# Metadata DB
DATABASE_URL: "postgresql://yugabyte:yugabyte@yugabyte-db:5433/langfuse"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urls are hardcoded

- sh
- -c
- |
bin/yugabyted start \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashetkar could you please cross-review the configurations of yb image here please.

krishna-yb and others added 3 commits March 16, 2026 08:06
Drop clickhouse-only compose wiring and web startup hard-fail, and default legacy clickhouse env keys in web env schema so yugabyte-only local startup works.
Replace deprecated URL validation and provide defaults for ClickHouse worker env keys so local Yugabyte-only setups do not fail env parsing.
@ashetkar
Copy link
Copy Markdown

@krishna-yb As a standard practice, please update the description of the PR to include what was changed and why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants